Improve file resource performance
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labocho Could you squash those commits? |
If file exists on remote and sha256sum command is available, compare digest and avoid unnecessary file transfer.
labocho
force-pushed
the
optimize-file-resource
branch
from
a088101 to
42aa18f
Compare
|
@unasuke Yes! Done. |
|
I released as |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now,
Itamae::Resource::File#pre_actionalways transfer file content. But when the file is not modified, it is not necessary and spends time.In this pull request, if the file exists on remote and
sha256sumcommand is available, compare digest and avoid unnecessary file transfer.30%+ faster in the benchmark below.
https://gist.github.com/labocho/23f8e089205a507e6089ce1e8ce5a863