Refine itamae docker's created message
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make `itamae docker` command to display tag name after the image is created if `tag` option is specified. For example: ``` $ bundle exec itamae docker --image base-image path/to/role.rb --tag awesome-something:latest (snip) INFO : Image created: sha256:24b0ede58da84ed28bafb629121d16b87e2d36cb96d8361413fdb2555876cac8, and tagged as awesome-something:latest ``` I think displaying created tag name is useful. It remind me the tag name. And it is the same behaviour with `docker build` command. ``` $ docker build -t foo:bar . (snip) Successfully built 24b0ede58da8 Successfully tagged foo:bar ```
unasuke
reviewed
May 10, 2019
Co-Authored-By: Yusuke Nakamura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make
itamae dockercommand to display tag name after the image is created iftagoption is specified.For example:
I think displaying created tag name is useful. It remind me the tag name.
And it is the same behaviour with
docker buildcommand.