-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only_if
and not_if
inside a define
#271
Conversation
only_if
and not_if
inside a define
1e59f57
to
2ea0535
Compare
only_if
and not_if
inside a define
only_if
and not_if
inside a define
@unasuke I removed WIP. Please review this 🙇 |
This implementation evaluates execute 'touch /tmp/a'
define :echo do
execute 'echo B'
end
execute 'echo A' do
only_if 'test -f /tmp/a'
end
echo 'echo' do
only_if 'test -f /tmp/a'
end
|
@ryotarai oops... I'll fix this. |
only_if
and not_if
inside a define
only_if
and not_if
inside a define
deff864
to
0ae12a9
Compare
0ae12a9
to
219e14e
Compare
219e14e
to
fdd5535
Compare
only_if
and not_if
inside a define
only_if
and not_if
inside a define
@ryotarai @unasuke I fixed this problem. Please review again 🙇 log that executed #271 (comment)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
c.f. #262
Example
Close #262
Close #161