Don't replace files when they will not be updated #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably addresses #174 |
|
Thank you! |
ryotarai
added a commit
that referenced
this pull request
Jan 24, 2016
Don't replace files when they will not be updated
|
Thank you for merging. |
|
released in v1.9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Updating files only when their contents will be updated is nice idea. I wrote patch for that.
Need I write test? If yes, we need to run test before and after running Itamae and it look over the top to me. That's why this pull request doesn't include test.
Background of this patch is:
I defined
notifiesto executerestorecontofileandtemplateresources. But current Itamae doesn't kicknotifiesif contents of files are not updated in spite of the files are replaced with files whose contents are the same and SELinux security contexts are changed. If this patch is applied, Itamae doesn't touch files if they will not be updated, so security context will not be changed.Could you consider the request?
Thanks.