Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redirect on http_request resource (close #187) #190

Conversation

hico-horiuchi
Copy link
Contributor

Happy new year 🎉
This is implementation of #187 based on chef/chef/lib/chef/http.rb.

For example:

http_request "/tmp/http_request_redirect.html" do
  redirect_limit 1
  url "https://httpbin.org/redirect-to?url=https%3A%2F%2Fhttpbin.org%2Fget%3Ffrom%3Ditamae"
end

@hico-horiuchi
Copy link
Contributor Author

@ryotarai The following errors are occured at wercker.
Would you check this problem?

 INFO :       package[dstat] installed will change from 'false' to 'true'
DEBUG :       Executing `dpkg-query -f '${Status}' -W dstat | grep -E '^(install|hold) ok installed$'`...
DEBUG :         stdout | dpkg-query: no packages found matching dstat
DEBUG :         exited with 1
DEBUG :       Executing `DEBIAN_FRONTEND='noninteractive' apt-get -y -o Dpkg::Options::='--force-confdef' -o Dpkg::Options::='--force-confold'  install dstat`...
DEBUG :         stdout | Reading package lists... 0%Reading package lists... 100%Reading package lists... Done
DEBUG :         stdout | Building dependency tree... 0%Building dependency tree... 0%Building dependency tree... 50%Building dependency tree... 50%Building dependency tree       
DEBUG :         stdout | Reading state information... 0%Reading state information... 1%Reading state information... Done
DEBUG :         stdout | The following packages were automatically installed and are no longer required:
DEBUG :         stdout |   linux-headers-3.13.0-57 linux-headers-3.13.0-57-generic
DEBUG :         stdout |   linux-headers-3.13.0-61 linux-headers-3.13.0-61-generic
DEBUG :         stdout |   linux-image-3.13.0-57-generic linux-image-3.13.0-61-generic
DEBUG :         stdout |   linux-image-extra-3.13.0-57-generic linux-image-extra-3.13.0-61-generic
DEBUG :         stdout | Use 'apt-get autoremove' to remove them.
DEBUG :         stdout | The following NEW packages will be installed:
DEBUG :         stdout |   dstat
DEBUG :         stdout | 0 upgraded, 1 newly installed, 0 to remove and 22 not upgraded.
DEBUG :         stdout | Need to get 68.2 kB of archives.
DEBUG :         stdout | After this operation, 351 kB of additional disk space will be used.
DEBUG :         stdout | WARNING: The following packages cannot be authenticated!
DEBUG :         stdout |   dstat
DEBUG :         stdout | E: There are problems and -y was used without --force-yes
ERROR :         Command `DEBIAN_FRONTEND='noninteractive' apt-get -y -o Dpkg::Options::='--force-confdef' -o Dpkg::Options::='--force-confold'  install dstat` failed. (exit status: 100)
ERROR :   package[dstat] Failed.

@hico-horiuchi hico-horiuchi force-pushed the support-redirect-on-http_request branch from fbe2bf0 to d930654 Compare January 2, 2016 12:06
@hico-horiuchi
Copy link
Contributor Author

Sorry, I amend the commit and force-pushed to retry tests.

@ryotarai
Copy link
Member

ryotarai commented Jan 3, 2016

Thank you!

ryotarai added a commit that referenced this pull request Jan 3, 2016
…equest

Support redirect on http_request resource (close #187)
@ryotarai ryotarai merged commit c4ec051 into itamae-kitchen:master Jan 3, 2016
@ryotarai
Copy link
Member

ryotarai commented Feb 3, 2016

released in v1.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants