Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve http_request resource to use net/http #184

Merged

Conversation

hico-horiuchi
Copy link
Contributor

Use net/http on http_request resource to available DELETE. OPTIONS, POST and PUT as action .
And message that is sent by the HTTP request can be set when POST and PUT.
(Those features are same as http_request of Chef.)

For example:

http_request "/tmp/http_request_post.html" do
  action :post
  message "love=sushi"
  url "https://httpbin.org/post?from=itamae"
end

However, the test of action :options is not yet added.
(httpbin does not support OPTIONS.)

@ryotarai
Copy link
Member

@hico-horiuchi I fixed dependency problem by 1284b84 . Would you rebase this PR?

@hico-horiuchi hico-horiuchi force-pushed the improve-http_request-resource branch from 27cd73e to beb2502 Compare December 19, 2015 15:47
@hico-horiuchi
Copy link
Contributor Author

@ryotarai Thank you!

ryotarai added a commit that referenced this pull request Dec 20, 2015
Improve http_request resource to use net/http
@ryotarai ryotarai merged commit 87d380b into itamae-kitchen:master Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants