Create http_request resource #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hico-horiuchi
changed the title
hico-horiuchi
force-pushed
the
create-http_request-resource
branch
from
3dc08a5 to
9f03fda
Compare
|
I apologize for many fixes. |
| @@ -70,6 +70,16 @@ | |||
| it { should_not be_file } | |||
| end | |||
|
|
|||
| describe file('/tmp/http_request.html') do | |||
| it { should be_file } | |||
| its(:content) { should match(/Itamae/) } | |||
There was a problem hiding this comment.
This looks assuming http://itamae.kitchen always return a body including Itamae but it can change.
There was a problem hiding this comment.
How about https://httpbin.org/get?from=itamae ?
|
That's great! |
|
Thank you for the fix. Would you rebase the commits? |
hico-horiuchi
force-pushed
the
create-http_request-resource
branch
from
ead3afa to
41776e3
Compare
|
Thank you for reviewing. |
| define_attribute :url, type: String | ||
|
|
||
| def pre_action | ||
| unless attributes.url |
There was a problem hiding this comment.
define_attribute accepts required option.
define_attribute :url, type: String, required: trueInstead of L13-L15, please use this.
|
Thank you for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create http_request resource for itamae.
This inherits file resource.
A example is shown in below.