Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support provider for service resource #134

Merged
merged 1 commit into from
May 20, 2015

Conversation

sonots
Copy link
Contributor

@sonots sonots commented May 20, 2015

Fix #132

Note that only :init and :systemd providers are fully implemented currently by specinfra.

daemontools provider requires another parameter for enable action (specinfra/daemontools.rb), so I don't support it with service resource, but daemontools_service resource https://github.com/sonots/itamae-plugin-resource-daemontools_service can be used.

PS. I could not find a suitable place to write tests, please let me know if there are.

Note that only `init` and `systemd` providers are fully implemented
currently.

`daemontools` provider requires another parameter for `enable` action, so
https://github.com/sonots/itamae-plugin-resource-daemontools_service
must be used.
@ryotarai
Copy link
Member

Thank you for your PR.

PS. I could not find a suitable place to write tests, please let me know if there are.

It's okay. I'll add tests...

ryotarai added a commit that referenced this pull request May 20, 2015
Support provider for service resource
@ryotarai ryotarai merged commit 832ee10 into itamae-kitchen:master May 20, 2015
@ryotarai
Copy link
Member

released in v1.2.17

@sonots sonots deleted the service_provider branch May 20, 2015 02:54
@sonots
Copy link
Contributor Author

sonots commented May 20, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting provider for service resource like chef
2 participants