events: improve removeListener() performance

array.shift() seems to be faster than arrayClone() when the item to remove is at the front (at least with V8 5.4). PR-URL: nodejs#10572 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
italoacasas · Jan 19, 2017 · 053fbb2 · 053fbb2
1 parent 0466b59
commit 053fbb2
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -360,6 +360,8 @@ EventEmitter.prototype.removeListener =
           } else {
             delete events[type];
           }
+        } else if (position === 0) {
+          list.shift();
         } else {
           spliceOne(list, position);
         }