-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA: implement prioritization/rate limitting #334
Comments
Dumb q - do we (or do we intend to) support the SDS protocol so that ztunnel could play nice with a compatible replacement workload CA/SDS, like the rest of Istio does today? |
I started #251 to define these integration interfaces. I hadn't put SDS in there but its plausible. I will say in general the idea has been to have a few common integration points. For example, instead of 10 telemetry providers just use OTEL, which itself supports the kitchen sink of providers. There is less of a standard around CAs compared to telemetry though. |
I've seen some semblance of this in the code; has this been implemented? |
yeah I think this is done. thanks! |
* Allow mismatched ns/hostnames and pick randomly based on services for the dst workload Signed-off-by: Kevin Dorosh <[email protected]> * Fix lint Signed-off-by: Kevin Dorosh <[email protected]> * Fix lint, again Signed-off-by: Kevin Dorosh <[email protected]> * Update test to cover multi namespace multi network Signed-off-by: Kevin Dorosh <[email protected]> * Remove dead code Signed-off-by: Kevin Dorosh <[email protected]> --------- Signed-off-by: Kevin Dorosh <[email protected]>
Depends on #298
Currently we have 3 sources of CA calls:
In order of important, this likely looks like: On Demand >>>> Background refresh when really close to expiration > Prewarming == Background refresh. Could be simplified to just "on demand is top priority".
Additionally, CA requests are expensive. 255 concurrent requests to 1 istiod would almost certainly overwhelm it (in CPU cost); other CAs may have different constraints. We are also not the only client. We need a sensible strategy that trades off not killing the CA with getting all the certs when we want.
At the very least, we should have a way to prioritize on demand requests. This could be something simple like adding some delay in prewarming, or have some priority queue.
The text was updated successfully, but these errors were encountered: