Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with upstream #5708

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Sync with upstream #5708

merged 2 commits into from
Jul 31, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Jul 31, 2024

fix: #5707

@zirain zirain requested a review from a team as a code owner July 31, 2024 14:38
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2024
zirain
zirain commented Jul 31, 2024
View reviewed changes
bazel/extension_config/extensions_build_config.bzl
@@ -230,7 +230,6 @@ ENVOY_EXTENSIONS = {
# Tracers
#

"envoy.tracers.dynamic_ot": "//source/extensions/tracers/dynamic_ot:config",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

envoyproxy/envoy#35418

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does Istio use this anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot recall

@istio-testing istio-testing merged commit c9b8ac3 into istio:master Jul 31, 2024
7 checks passed
@zirain zirain deleted the sync-with-upstream branch August 1, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov left review comments

@howardjohn howardjohn howardjohn approved these changes

@keithmattix keithmattix keithmattix approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zirain @howardjohn @keithmattix @kyessenov @istio-testing