Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseURL for develop mode #2861

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Add baseURL for develop mode #2861

merged 1 commit into from
Nov 12, 2018

Conversation

clyang82
Copy link
Member

Add baseURL for hugo serve command to have http://localhost:1313/ instead of //localhost:1313/
Before Fix:
make serve

docker run -t -i --sig-proxy=true --rm -v /Users/clyang/go/src/istio.io/istio.io:/site -w /site -p 1313:1313 gcr.io/istio-testing/website-builder:2018-10-08 hugo serve --bind 0.0.0.0 --disableFastRender

                   | EN  | ZH   
+------------------+-----+-----+
  Pages            | 520 | 503  
  Paginator pages  |   0 |   0  
  Non-page files   | 122 | 119  
  Static files     |  56 |  56  
  Processed images |   0 |   0  
  Aliases          | 139 |   1  
  Sitemaps         |   2 |   1  
  Cleaned          |   0 |   0  

Total in 3563 ms
Watching for changes in /site/{assets,content,content_zh,data,i18n,layouts,static}
Watching for config changes in /site/config.toml
Serving pages from memory
Web Server is available at //localhost:1313/ (bind address 0.0.0.0)
Press Ctrl+C to stop

After Fix:

docker run -t -i --sig-proxy=true --rm -v /Users/clyang/go/src/istio.io/istio.io:/site -w /site -p 1313:1313 gcr.io/istio-testing/website-builder:2018-10-08 hugo serve --baseURL "http://localhost:1313/" --bind 0.0.0.0 --disableFastRender

                   | EN  | ZH   
+------------------+-----+-----+
  Pages            | 520 | 503  
  Paginator pages  |   0 |   0  
  Non-page files   | 122 | 119  
  Static files     |  56 |  56  
  Processed images |   0 |   0  
  Aliases          | 139 |   1  
  Sitemaps         |   2 |   1  
  Cleaned          |   0 |   0  

Total in 3690 ms
Watching for changes in /site/{assets,content,content_zh,data,i18n,layouts,static}
Watching for config changes in /site/config.toml
Serving pages from memory
Web Server is available at http://localhost:1313/ (bind address 0.0.0.0)
Press Ctrl+C to stop

Signed-off-by: clyang82 [email protected]

Signed-off-by: clyang82 <[email protected]>
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clyang82
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smawson

If they are not already assigned, you can assign the PR to them by writing /assign @smawson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Contributor

Hi @clyang82. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants