Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update refdocs 1.24 to use markdown links and standardize HTTP/2 notation #3431

Closed

Conversation

AdeshGhadage
Copy link

Converted inline URLs to markdown format in refdocs. Standardized "HTTP2" to "HTTP/2". Changes made in the release branch of istio/api. This aligns with issue.

@AdeshGhadage AdeshGhadage requested a review from a team as a code owner February 4, 2025 13:16
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Feb 4, 2025
@istio-testing
Copy link
Collaborator

Hi @AdeshGhadage. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Member

zirain commented Feb 4, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 4, 2025
@istio-testing
Copy link
Collaborator

@AdeshGhadage: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api_release-1.24 0bd7e09 link false /test release-notes
gencheck_api_release-1.24 0bd7e09 link true /test gencheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mikemorris
Copy link
Member

@craigbox Is separate PRs the expected approach here, or should #3430 be backported?

@craigbox
Copy link
Contributor

craigbox commented Feb 4, 2025

Yes; @AdeshGhadage, this should be fixed in #3430, pass all the tests, etc.
We may not need to cherry pick if this lands before 1.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants