Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External sourcemap fix #696

Closed
wants to merge 5 commits into from
Closed

External sourcemap fix #696

wants to merge 5 commits into from

Conversation

thegecko
Copy link
Contributor

This PR contains two fixes:

  • a fix for external sourcemaps which weren't being loaded properly
  • added a missing callback

@thegecko
Copy link
Contributor Author

I think a similar fix is needed for picking up the correct files when creating a report. I am on holiday now, bit will investigate upon my return and add another PR then.

@bcoe bcoe mentioned this pull request Oct 23, 2017
Merged
@thegecko
Copy link
Contributor Author

@bcoe I can see #697 has gone some way to fixing this issue. There are still a few minor fixes in this PR which I'll pull out into a fresh one.

@thegecko thegecko closed this Oct 29, 2017
@thegecko thegecko mentioned this pull request Oct 29, 2017
Merged
@bcoe
Copy link
Member

bcoe commented Oct 30, 2017

@thegecko awesome 👍 I'm glad we're starting to get things sorted out better for folks who pre-instrument their files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thegecko @bcoe