[WIP] Feat/add tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanyee
force-pushed
the
feat/add-tests
branch
from
a9f51e0 to
921c128
Compare
jordanyee
force-pushed
the
feat/add-tests
branch
2 times, most recently
from
3f5c766 to
c3608e5
Compare
Includes FIXME regarding verifying `svg2png` and `writeFileSync` not being implemented along with the latest attempt.
…files are written to file system at the right size
…g and unlinking files once
jordanyee
force-pushed
the
feat/add-tests
branch
from
c3608e5 to
5c6a440
Compare
…mise doesn't resolve Without these changes the test will just hang because `done()` is never called.
… complete before executing test Otherwise `parseXML` may read the config file before it is written and return an empty string which in turn causes `parser.parseString` to fail even though the test may (also sometimes) return true because it reads both the fixture and temp fixture later to do the equality test.
Makes tests fail more gracefully.
…ment to use `src`
Enables `let`
Enables `let`
Enables `let`
Fixes racy test execution resulting in intermittent failures.
… and dependancies
…elper and dependancies
… helper and dependancies
jordanyee
force-pushed
the
feat/add-tests
branch
from
4a40d3d to
d5e8f9c
Compare
|
Ready for review 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.