Build Config with Cordova Tab Width Default #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexblom Just updated the XML building to use Cordova's default of 4-space wide tabs. Mind reviewing before I merge? |
kitsunde
reviewed
Oct 6, 2016
| renderOpts: { | ||
| 'pretty': true, | ||
| 'indent': ' ', | ||
| 'newline': '\n' |
There was a problem hiding this comment.
Can't this be CRLF on windows? You might need to detect the line ending so it doesn't make the whole file show up as changed.
There was a problem hiding this comment.
For now we're gonna leave this as a \n as we have other more pressing items.
That said, as @alexblom said we're moving towards treating config.xml as a temporary file. And with that in mind, once it is committed as a file with \n line endings, subsequent changes should (also using the \n line endings) just show the single lines changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by kitsunde, splicon currently builds
config.xmlwith 2-space wide tabs rather than the Cordova default of 4-space wide tabs.Cordova's default of 4-space wide tabs should be respected.