Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in LegoWorld::Enable #1329

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

foxtacles
Copy link
Member

No description provided.

@foxtacles foxtacles requested a review from disinvite January 11, 2025 16:15
@disinvite
Copy link
Collaborator

Thanks. I think that was just my goof. size() == 0 is correct for both:

@@ BETA10 0x100dbacb @@
call Thunk of 'set<MxCore *,CoreSetCompare,allocator<MxCore *> >::size' (FUNCTION)
test eax, eax
-jne 0x3a5
+jne 0x3a2
call Thunk of 'UserActor' (FUNCTION)

@foxtacles foxtacles merged commit 5c57b80 into isledecomp:master Jan 11, 2025
12 checks passed
@foxtacles foxtacles deleted the worlden branch January 11, 2025 18:39
Jardynq pushed a commit to Jardynq/LegoIsleN64 that referenced this pull request Feb 17, 2025
* Fix regression in `LegoWorld::Enable`

* Update legoworld.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants