Implement HiveBuilder, obey lints #25
Conversation
| @@ -54,14 +55,17 @@ class TodoList extends StatelessWidget { | |||
| icon: Icon(todo.done ? Icons.clear : Icons.check), | |||
| onPressed: () { | |||
| var newTodo = todo.copyWith(done: !todo.done); | |||
| Hive.box('todos') | |||
| .deleteAt(Hive.box('todos').values.toList().indexOf(todo)); | |||
There was a problem hiding this comment.
Why did you replace delete(todo.id) with deleteAt(Hive.box('todos').values.toList().indexOf(todo))?
Deleting by key is much faster than your solution. You have to copy all todo items to a list, find the one to be deleted. Hive will then internally walk through all the values again to find the key of the todo item.
There was a problem hiding this comment.
I tried it with the delete solution, it didn't work on my Pixel 3 XL emulator
There was a problem hiding this comment.
Strange. I'll test it on the emulator...
Edit: Does the web version work for you: https://leisim.github.io/hive/demos/todo
There was a problem hiding this comment.
Web version works for me, but when I restart the app on my emulator, it shows some weird behavior !
https://imgur.com/a/GPRXCQ2
I made sure, that the delete statement gets called.
| Hive.box('todos').put(newTodo.id, newTodo); | ||
| }, | ||
| ), | ||
| IconButton( | ||
| iconSize: 30, | ||
| icon: Icon(Icons.delete), | ||
| onPressed: () { | ||
| Hive.box('todos').delete(todo.id); | ||
| Hive.box('todos') | ||
| .deleteAt(Hive.box('todos').values.toList().indexOf(todo)); |
There was a problem hiding this comment.
I tried it with the delete solution, it didn't work on my Pixel 3 XL emulator
| /// [openBox] function is loaded. While the box is not loaded a placeholder | ||
| /// [placeholderBuilder] is specified to inform the user. In the case of the | ||
| /// box failing to open an error widget [errorBuilder] is displayed. | ||
| class HiveBuilder extends StatelessWidget { |
There was a problem hiding this comment.
The HiveBuilder was initially part of hive_flutter because I found it useful. But it is not much more than a fancy FutureBuilder. Since handling Futures is a general Flutter problem and has nothing to do with Hive, I'm not sure if it should be included.
|
Unfortunately I could not merge this PR due to conflicts but all of your suggestions have been addressed. Thanks! |
No description provided.