Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.4.0 #11

Merged
merged 22 commits into from
Aug 17, 2019
Merged

0.4.0 #11

merged 22 commits into from
Aug 17, 2019

Conversation

simc
Copy link
Member

@simc simc commented Aug 4, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 4, 2019

Codecov Report

Merging #11 into master will increase coverage by 1.57%.
The diff coverage is 95.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   93.37%   94.95%   +1.57%     
==========================================
  Files          29       30       +1     
  Lines         906     1011     +105     
==========================================
+ Hits          846      960     +114     
+ Misses         60       51       -9
Impacted Files Coverage Δ
hive/lib/src/box/box_options.dart 100% <ø> (ø) ⬆️
hive/lib/hive.dart 0% <ø> (ø) ⬆️
hive/lib/src/binary/binary_writer_impl.dart 93.89% <0%> (-0.73%) ⬇️
hive/lib/src/io/buffered_file_reader.dart 100% <100%> (ø) ⬆️
hive/lib/src/box/box.dart 100% <100%> (ø) ⬆️
hive/lib/src/box/box_impl.dart 100% <100%> (+5.69%) ⬆️
hive/lib/src/box/change_notifier.dart 100% <100%> (ø) ⬆️
hive/lib/src/io/synced_file.dart 83.33% <100%> (+19.04%) ⬆️
hive/lib/src/binary/binary_reader_impl.dart 95.23% <71.42%> (-1.57%) ⬇️
hive/lib/src/hive_impl.dart 92.3% <78.57%> (+17.3%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b23e28...902d439. Read the comment docs.

@@ -40,7 +40,7 @@ class IceCreamPage extends StatefulWidget {
}

class _IceCreamPageState extends State<IceCreamPage> {
var box = Hive['myBox'];
var box = Hive.box('myBox');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, could you just help me understanding this?
i think here it should be Hive.openBox just like in the other files.
If not, what is different here that it doesn't need to usar de openBox method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, in the _openBox() method, Hive.openBox() should be called.
Once a box has been opened, it can be accessed without a Future using Hive.box().

This pull request ist WIP and I'll update the documentation to explain the difference in detail...

@simc simc merged commit d79e86a into master Aug 17, 2019
@simc simc deleted the dev branch August 17, 2019 00:03
simc added a commit that referenced this pull request Sep 16, 2019
simc added a commit that referenced this pull request Sep 24, 2019
simc added a commit that referenced this pull request Feb 13, 2020
@muhammednazil muhammednazil mentioned this pull request Jan 4, 2021
@chandrabezzo chandrabezzo mentioned this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants