-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#692,proposed fixes for ratings #694
Conversation
Build Successful! You can find a link to the downloadable artifacts below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if I earn a very special frown from @gernotstarke for being extraordinarily nit-picky: For the sake of consistency (see e.g. LG 03-08, same situation there): If we don't have a R2 learning goal in here, it should be (R1, R3), not (R1-R3).
Personally I find the latter visually much more pleasing, but it's not consistent.
A (in my opinion) acceptable compromise between visually appealing and correct would be to consistently use the notation (R1+R3) in such cases.
Meanwhile, in the department of microscopic problems... ;-)
@alxlo, Monsieur PEP (Personne extraordinairement pointilleuse), you are obviously very right in your observation concerning consistency. I change the rating back to (R1,R3) - as NOT to introduce another symbol (+). As we deleted R2 in the EN version of this LG, this seems the most consistent approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! (Belatedly.)
@michaelpog please also have a look.
I changed the rating in the LG title from (R1,R3) to "R1-R3" and removed one R2 in the EN version
(seems the DE version was more consistent)