Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#692,proposed fixes for ratings #694

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

gernotstarke
Copy link
Member

@michaelpog please also have a look.

I changed the rating in the LG title from (R1,R3) to "R1-R3" and removed one R2 in the EN version
(seems the DE version was more consistent)

@gernotstarke gernotstarke added bug Something isn't working V2025 Release 2025 labels Jan 10, 2025
@gernotstarke gernotstarke self-assigned this Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Copy link
Contributor

@alxlo alxlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if I earn a very special frown from @gernotstarke for being extraordinarily nit-picky: For the sake of consistency (see e.g. LG 03-08, same situation there): If we don't have a R2 learning goal in here, it should be (R1, R3), not (R1-R3).
Personally I find the latter visually much more pleasing, but it's not consistent.
A (in my opinion) acceptable compromise between visually appealing and correct would be to consistently use the notation (R1+R3) in such cases.

Meanwhile, in the department of microscopic problems... ;-)

@gernotstarke
Copy link
Member Author

@alxlo, Monsieur PEP (Personne extraordinairement pointilleuse), you are obviously very right in your observation concerning consistency. I change the rating back to (R1,R3) - as NOT to introduce another symbol (+). As we deleted R2 in the EN version of this LG, this seems the most consistent approach.

@alxlo alxlo self-requested a review January 12, 2025 14:55
@gernotstarke gernotstarke merged commit 930fdd8 into main Jan 12, 2025
1 check passed
@gernotstarke gernotstarke deleted the #692-LG-05-02-consistent-ratings branch January 12, 2025 16:10
Copy link
Contributor

@mikesperber mikesperber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! (Belatedly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V2025 Release 2025
Projects
Status: Done / Implemented
Development

Successfully merging this pull request may close these issues.

3 participants