-
Notifications
You must be signed in to change notification settings - Fork 131
Auto-magically & retroactively have posts that are only ±1, &c, converted to reactions & hidden/deleted #640
Comments
👍❤️ |
If this is ever implemented, the intermediate post should evaporate & convert to reactions on original post. 😜 |
Response from GitHub:
|
@sergei-ivanov I'm honored by your support! 🙇 |
Another issue that would benefit enormously from this is #215! 😵 |
I think there are two different issues:
|
@The-Compiler I suppose 1 could split this into 2 (i.e., pt.1="retroactively" & pt.2="auto-magically"), but neither part is particularly satisfactory on its own, & I think the same backend implementation could handle both more easily than just 1-or-the-other. |
From @radek-holy:
I'll reply here as not to spam #283: Practically, such non-content support 👍s are spam on the channel for everyone else who's subscribed (so is inherently selfish), & causes other problems as detailed above. I'd rather have those folks put the effort into a useful response/comment, |
Response from GitHub:
|
Hey, @Mottie, if you want a really good challenge, userscript this! 🙇 |
From looking at the reactions API, you can create a reaction, but it will only be your reaction; there is no way that I can see to add more than one thumbs up to the top issue. Also, you would need to have authorization to edit or delete "+1" comments from the thread. I really wish there was some way to add a webhook or service integration where when someone only posts a "+1" or equivalent, it automatically adds it as a reaction to the OP in their name and deletes the comment. It wouldn't solve this issue of converting retroactive "+1s", but it may stop people from their current bad habits. |
I didn't mean as an actual implementation of the whole functionality, but merely what 1 sees: Something like (on top post) "862 👍s removed & should be added here" or some such, but less tacky wording. 😜 |
The GitHub issue comments userscript will hide "+1" comments - it also hides stuff like "+1!!!", "++1", "+9999", "+1 please", ":+1:" (including a wall of +1's), ":100:", etc. It won't hide the comment if there is more text than that. I just updated the userscript to include a count of how many comments were hidden. So, it won't count comments that have a "+1" with an explanation... In #215, the userscript initially hides 112 comments, but after you click "view more" - and check & uncheck the "Hide +1s" option (I still need to fix this) - it shows that a total of 197 comments are hidden. |
@Mottie The only addition I can think of that's possible, perhaps: add, e.g., those 197 👍s, to the top-post's 👍-count or as an additional "& scraped: 197 👍" box in that line. Still, you 🤘! |
Ok, latest update will now add a little extra comment to the top post If there isn't a +1 reaction, it adds a comment to the post I ended up tweaking the code a little so the hidden +1 count may be a little different. Also, it automatically updates after more comments are loaded using the "View more" button. Note: A comment may be hidden if someone posts one or even a bunch of random emoji like 💀 (no text), and that will end up getting counted as a +1. |
Oh weird... I guess the thumbs up button can have different values. That's why the "256 (from hidden comments)" isn't inside the button. I'll fix that when I get some time today. The |
@Mottie I see ":+1: 1 (from hidden comments)" on this issue, though #640 (comment) & #640 (comment) should be 2, right? Both comments are properly disappeared, though. |
Internally, the code keeps a list of the names of all commenters, so duplicate posts with a +1 are ignored. |
Yes, but the 2 👍 posts are from myself & @marcelmfs. Are you saying @marcelmfs both posted & 👍ed the original post? |
Your original post (the first one) has a +1, thumbs up, 100... and all that stuff that counts as a +1 by the algorithm. So the second post is considered a duplicate. |
I've made a GitHub App that deletes +1 comments, and encourages people to use reactions instead. 🎉 |
@dessant Fantastic! Now only if @github / @microsoft would install this globally! A suggestion/clarification: Does that "Edit Issues" permission allow to accomplish the rest of this RFE, adding the reaction meant by the now-deleted post? |
@TPS, the permission is used to edit/delete comments. GitHub Apps cannot submit reactions, that is reserved to OAuth Apps, though those need to be installed individually by the user. There is no clear way to solve this ourselves at the org level, short of creating a fake reaction bar at the bottom of the issue body that imitates the real one and increments reaction counts there. That would still be a muddy solution, because you cannot guess the intentions of the user, did they react to a recent comment with a +1, or are they agreeing with the goals of the entire issue? You would see otherwise misguided issues that received a reasonable comment along the way appear to have the support of the community. A sensible approach would be to educate users, show a warning about the consequences of a +1 comment when they are about to submit the post, and suggest the use of reactions instead. I agree this could be implemented globally by GitHub. |
refined-github/refined-github#1526 was somewhat implemented here |
Hello all! I'm a PM at GitHub and I just wanted to leave a note here to say that we shipped something that should hopefully help with this: https://blog.github.com/changelog/2018-09-24-hiding-repeat-comments/ I know that this solution doesn't absolutely address the title above – so I don't expect it to close this issue out – but I hope that it goes some way to help 🧡. I'd love to know your feedback. How can we iterate to make this better? For the slightly different problem of stopping people from posting "just +1" posts in the first place – we're currently investigating what we can do there too! |
@lukehefson Thanks very much for your attention! 🙇 This is indeed a very welcome stopgap toward implementing my (😜) issue, & it works beautifully. A couple RFC/Es:
OT: I created a PushBullet channel @ https://www.pushbullet.com/channel?tag=githubchangelog to (try to) keep track of all the great work y'all're doing. ☺ |
This comment has been minimized.
This comment has been minimized.
@JayFoxRox, @kenorb, @Arzte: I noticed that y'all expressed some concerns (via reactions on OP, above), but haven't otherwise detailed via comments. I'd like to explicitly invite y'all to do so, especially since we've @github's 👀 via @lukehefson! @marcelmfs C'mon, again? Haven't we been through this already |
Some new feature has been implemented, by grouping multiple "+1" posts, but I can't find the article about it. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@TPS thanks to this thread I can confirm that it does not suppress email notifications 😞 |
To provide another perspective, in other cases it is a good thing that email notification is always sent. For example, if you have a GitHub
integration that sends some kind of automated message by posting a comment
on the pull request, then it's good that the emails are sent on each message.
Of course, this doesn't reduce the email spam for the +1s.
|
To fix issues like #18 recently not loading because of death by 1300 (❕:bangbang:❗) 👍s
{?}, multi-/mega-👍s, & related should count, too — bonus points for "me, too" & equivalents), -1 (& related), &/or all other supplied reactions, convert them to reactions on the top/previous non-reaction-only post (repo owner's choice), & then hide/delete from view or thread outright. (Also, if any, reactions on said extraneous posts should be outright ignored!)
It'd instantly solve such subscription-spamming (does anyone sane need e-mail notification on these posts?!), as well.
(& then having to be refiled in #604 to work-around), GitHub should now automatically & retroactively find all posts everywhere that consist solely of +1 (👍, +100, 💯, +∞,To give credit where due, @eddiemonge proposed this way back in April 23, 2015 & @andreynering on March 30, 2016!
↓ Don't just react
& don't +1/👍-only post
: Contact GitHub supporting this, also, & report back! ↓The text was updated successfully, but these errors were encountered: