Period values changed as discussed on 2020-12-17 TC Call #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xed typo on limit description
pjmolina
requested changes
Dec 18, 2020
| @@ -223,7 +223,7 @@ Describes the general information of the pricing of the a given plan. | |||
| | :------------- | :------------:| :------------| | |||
| | cost | `number` | **Optional** Units of cost associated with this service. Defaults to `0` if unspecified. | | |||
| | currency | `string` | **Optional** Currency used to express the cost. Supported currency values are expressed in [ISO 4217](https://en.wikipedia.org/wiki/ISO_4217) format. Samples: `USD`, `EUR`, or `BTC` for US dollar, euro, or bitcoin, respectively. Defaults to `USD` if unspecified. | | |||
| | billing | `string` | **Optional** Period used for billing. Possible values are: `onepay`, an unique payment before start using the service; `daily` , billed every day; `weekly`, billed every week; `monthly`, billed every month; `quarterly`, billed every quarter; `yearly`, billed every year. If it is not specified, the default value assumed is `monthly`| | |||
| | billing | `string` | **Optional** Billing frequency. Possible values are: `onepay`, an unique payment before start using the service; `daily` , billed every day; `weekly`, billed every week; `monthly`, billed every month; `quarterly`, billed every quarter; `yearly`, billed every year. If it is not specified, the default value assumed is `monthly`| | |||
There was a problem hiding this comment.
- Keep Period: 1 month period is correct. Monthly means frequency.
- Remove
dailyweeklymonthlyquarterlyfrom the description.
There was a problem hiding this comment.
In my understanding, we discussed that periods for limitations is different from the billing. In the first case of a period, it was better to change values to remove the "-ly" suffix (e.g. second) but in the second case , as it is clearly a frequency, we should keep the "-ly" suffix (e.g. yearly) starting on monthly.
pjmolina
approved these changes
Jan 14, 2021
timburks
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed possible period values for limits, improve description and fixed typo on limit description