Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented storage encryption feature support #618

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Implemented storage encryption feature support #618

merged 8 commits into from
Jan 26, 2023

Conversation

kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented Jan 24, 2023 •
edited
Loading

Proposed Changes

  • Add new optional field encryption with single attribute secretRef in VolumeSpec
  • Add validations to check secretRef attribute is immutable and secretRef.name is not empty.
  • Modify volume-test.go to add encryption field testcases
  • Modify api reference docs using gen-crd-api-reference-docs

@kasabe28 kasabe28 requested a review from a team as a code owner January 24, 2023 10:17
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request size/XXL labels Jan 24, 2023
adracus
adracus suggested changes Jan 24, 2023
View reviewed changes
api/storage/v1alpha1/volume_types.go Outdated Show resolved Hide resolved
api/storage/v1alpha1/volume_types.go Outdated Show resolved Hide resolved
onmetal-apiserver/internal/apis/storage/validation/volume.go Outdated Show resolved Hide resolved
@kasabe28 kasabe28 linked an issue Jan 25, 2023 that may be closed by this pull request
Add storage encryption feature to Volume #616
Closed
@adracus adracus merged commit 131d052 into main Jan 26, 2023
@adracus adracus deleted the feature/storage-encryption branch January 26, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushabelgur ushabelgur ushabelgur left review comments

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add storage encryption feature to Volume
3 participants
@kasabe28 @adracus @ushabelgur