Simplify & Fix Prefix / PrefixAllocation
#408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a `Phase` for `Prefix` / `PrefixAllocation` as we have it for e.g. `VirtualIP`. This makes more sense for several reasons: * Code reading and writing the phase is much simpler * Transitioning between multiple different states and encoding it into a `Reason` field of a condition fuzzes the line of when to actually update the `LastTransitionTime` of a condition (that actually should only change when updating between `Unknown`, `True` and `False`). Fix some additional issues.
github-actions
bot
added
api-change
bug
afritzler
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a
PhaseforPrefix/PrefixAllocationas we have itfor e.g.
VirtualIP. This makes more sense for several reasons:Reasonfield of a condition fuzzes the line of when to actuallyupdate the
LastTransitionTimeof a condition (that actually shouldonly change when updating between
Unknown,TrueandFalse).Fix some additional issues.