Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong restconfig reference when using a bootstrap kubeconfig #1120

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix wrong restconfig reference when using a bootstrap kubeconfig #1120

merged 1 commit into from
Sep 10, 2024

Conversation

nitrocb
Copy link
Contributor

@nitrocb nitrocb commented Sep 9, 2024 •
edited by afritzler
Loading

Proposed Changes

  • Changes to the correct restconfig in case a bootstrap-kubeconfig is used
  • Prevents panic in case only bootstrap-kubeconfig is used to generate real kubeconfig

@nitrocb nitrocb requested a review from a team as a code owner September 9, 2024 17:30
@github-actions github-actions bot added bug Something isn't working size/XS labels Sep 9, 2024
@afritzler afritzler changed the title fixing wrong restconfig reference Fix wrong restconfig reference when using a bootstrap kubeconfig Sep 10, 2024
afritzler
afritzler approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitrocb thanks a lot!

@afritzler afritzler merged commit 49fbe45 into ironcore-dev:main Sep 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocb @afritzler