Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform-miyoo: change to IPK release output #133

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Apaczer
Copy link

@Apaczer Apaczer commented Jul 11, 2024

This requires to update miyoo container, so it can rely on current SDK with gm2xpkg ver. 0.4 in it.

You might want consider sending this script output to /dev/null as it in dev stage and will print some useless info.

@irixxxx
Copy link
Owner

irixxxx commented Jul 12, 2024

Just in time for 2.00 release which will happen this weekend. My bug list actually emptied this week.
Is the container Dockerfile in my toolchains repo still valid?
Is this needing additional testing before release?

@irixxxx irixxxx force-pushed the release-prepare branch 3 times, most recently from 8b6d023 to 29dcbc5 Compare July 12, 2024 07:27
create `platform/miyoo/pkg.cfg`
@Apaczer
Copy link
Author

Apaczer commented Jul 12, 2024

Is the container Dockerfile in my toolchains repo still valid?

Yes, nothing changed in that regard.

Is this needing additional testing before release?

Did a quick run, seems ok. For the menu btn I would use also SDLK_RCTRL aka RESET/HOME button on console itself, if possible.

@irixxxx
Copy link
Owner

irixxxx commented Jul 12, 2024

It should be possible for 2 buttons to have the same action, by duplicating platform/opendingux/inputmap.c line 22 and changing the key in the duplicate. Never tried that though...

@Apaczer
Copy link
Author

Apaczer commented Jul 12, 2024

If there is no big reason to use SELECT (current menu btn), then I would simply change it to RESET/HOME btn for streamlining with other apps.

@irixxxx
Copy link
Owner

irixxxx commented Jul 12, 2024

The code is shared with other devices using SDL. I can't just change that key since those don't have RCTRL. It might be possible to have it patched like other key related stuff, though.

@irixxxx irixxxx merged commit 62dd619 into irixxxx:release-prepare Jul 12, 2024
13 of 14 checks passed
@irixxxx
Copy link
Owner

irixxxx commented Jul 12, 2024

I've fixed up the CI and added that additional key to the inputmap. I also had to jump through some hoops to get the toolchain containers back into working order, since od.abstration.se doesn't exist anymore and I had to switch to a newer opendingux beta toolchain.

I hope everything is still in working order. Please do me a favour and check the results from the actions tab. It would also be nice if you could test some of the opendingux and odbeta builds, since toolchain changes might quickly lead to broken executables, especially for opendingux where I mix 2 toolchains for better (i.e. faster) results.

@Apaczer Apaczer deleted the miyoo-ipk branch July 13, 2024 08:13
@Apaczer
Copy link
Author

Apaczer commented Jul 13, 2024

Tks, will test in 2 days for miyoo, but I do not own any of opendingux/odbeta devices. However I can't see changes in inputmap, u sure did a push? Was thinking about adding swap in plat_target_input for miyoo (all of them have RCTRL under RESET btn AFAIK) if that fails.

@irixxxx
Copy link
Owner

irixxxx commented Jul 13, 2024

Oh yes, pushed the wrong branch to release-testing. I've reverted to the simple solution and just use both buttons for the menu. It shouldn't do any harm as far as I can see, and anyone needing it can easily override the binding in the hotkey settings.

@irixxxx
Copy link
Owner

irixxxx commented Jul 13, 2024

Scrap that, it creates too many problem with other opendingux-like devices. I've replaced that "simple" solution with a bind patch for miyoo.

@Apaczer
Copy link
Author

Apaczer commented Jul 14, 2024

Ok, fresh install from auto-build looks good with IPK and swapped btn. The SMS roms also play better I believe (that is compare to the build from end of last year). 👌

@irixxxx
Copy link
Owner

irixxxx commented Jul 15, 2024

Thx. For testing! Definitely saves me some time.

Yes, IMHO SMS support is now quite mature, I think. The only know issue is some improper VDP timing, but I haven't found any gfx glitches during my tests. I reckon it's probably quite rare if at all.

I need to test opendingux (at least rg350 and gkd) and odbeta (gcw0 should suffice I think). If that's successful all lights are on green for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants