-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
platform-miyoo: change to IPK release output #133
Conversation
Just in time for 2.00 release which will happen this weekend. My bug list actually emptied this week. |
8b6d023
to
29dcbc5
Compare
create `platform/miyoo/pkg.cfg`
Yes, nothing changed in that regard.
Did a quick run, seems ok. For the menu btn I would use also SDLK_RCTRL aka RESET/HOME button on console itself, if possible. |
It should be possible for 2 buttons to have the same action, by duplicating platform/opendingux/inputmap.c line 22 and changing the key in the duplicate. Never tried that though... |
If there is no big reason to use SELECT (current menu btn), then I would simply change it to RESET/HOME btn for streamlining with other apps. |
The code is shared with other devices using SDL. I can't just change that key since those don't have RCTRL. It might be possible to have it patched like other key related stuff, though. |
I've fixed up the CI and added that additional key to the inputmap. I also had to jump through some hoops to get the toolchain containers back into working order, since od.abstration.se doesn't exist anymore and I had to switch to a newer opendingux beta toolchain. I hope everything is still in working order. Please do me a favour and check the results from the actions tab. It would also be nice if you could test some of the opendingux and odbeta builds, since toolchain changes might quickly lead to broken executables, especially for opendingux where I mix 2 toolchains for better (i.e. faster) results. |
Tks, will test in 2 days for miyoo, but I do not own any of opendingux/odbeta devices. However I can't see changes in inputmap, u sure did a push? Was thinking about adding swap in plat_target_input for miyoo (all of them have RCTRL under RESET btn AFAIK) if that fails. |
Oh yes, pushed the wrong branch to release-testing. I've reverted to the simple solution and just use both buttons for the menu. It shouldn't do any harm as far as I can see, and anyone needing it can easily override the binding in the hotkey settings. |
Scrap that, it creates too many problem with other opendingux-like devices. I've replaced that "simple" solution with a bind patch for miyoo. |
Ok, fresh install from auto-build looks good with IPK and swapped btn. The SMS roms also play better I believe (that is compare to the build from end of last year). 👌 |
Thx. For testing! Definitely saves me some time. Yes, IMHO SMS support is now quite mature, I think. The only know issue is some improper VDP timing, but I haven't found any gfx glitches during my tests. I reckon it's probably quite rare if at all. I need to test opendingux (at least rg350 and gkd) and odbeta (gcw0 should suffice I think). If that's successful all lights are on green for the release. |
This requires to update miyoo container, so it can rely on current SDK with
gm2xpkg
ver. 0.4 in it.You might want consider sending this script output to /dev/null as it in dev stage and will print some useless info.