-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump up mods.irisnet.org/modules/random to cosmos-sdk v0.50.10 #453
Merged
Merged
Changes from 9 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Context migration needed in random module
The verification reveals several functions in the random module that still use the old
sdk.Context
pattern and need to be migrated to the new context handling approach:modules/random/module.go
: ExportGenesismodules/random/genesis.go
: InitGenesis, ExportGenesis, PrepForZeroHeightGenesismodules/random/keeper/keeper.go
: Multiple keeper methods including Logger, SetRandom, GetRandom, etc.modules/random/keeper/service.go
: GetMaxServiceRequestTimeout and other service-related methodsThese functions should be updated to:
context.Context
instead ofsdk.Context
sdk.UnwrapSDKContext()
within the function body🔗 Analysis chain
LGTM: Context handling follows SDK v0.50.10 patterns
The BeginBlocker signature change and context unwrapping implementation follow the correct patterns for cosmos-sdk v0.50.10.
Let's verify consistent context handling across the codebase:
Let me generate another verification script to check for any remaining direct sdk.Context usage that might need migration:
This will help us verify if there are any remaining instances of direct sdk.Context usage in the random module that might need to be migrated to the new context pattern.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 10058
Script:
Length of output: 4770