Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add chain-id value checking for sign command #848

Merged
merged 1 commit into from
Dec 18, 2018
Merged

R4R: Add chain-id value checking for sign command #848

merged 1 commit into from
Dec 18, 2018

Conversation

HaoyangLiu
Copy link

@HaoyangLiu HaoyangLiu commented Dec 18, 2018

cmd.MarkFlagRequired(client.FlagChainID)

The above code doesn't make sense. Because flag client.FlagChainID is not defined in this field.

@wukongcheng wukongcheng merged commit 91f714e into irisnet:develop Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants