R4R: user guide for bank #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengwenxi
force-pushed
the
feature/docs
branch
3 times, most recently
from
74f3825 to
b4049b4
Compare
chengwenxi
force-pushed
the
feature/docs
branch
from
b4049b4 to
5c782c8
Compare
chengwenxi
force-pushed
the
feature/docs
branch
from
bd1b782 to
d64e84f
Compare
HaoyangLiu
reviewed
Nov 18, 2018
| 5. Broadcast transactions | ||
|
|
||
| Broadcast signed transactions generated offline, using the final generated file in step 4: | ||
| ```bash |
There was a problem hiding this comment.
Broadcast signed transactions generated offline, using the final generated file in step 4:
How about change the sentence like this:
Broadcast offline signed transaction. Here you just use the transaction generated by above sign command. Of course, you can generate your signed transaction by any methods. Just make sure your signature and public key are amino encoding.
HaoyangLiu
reviewed
Nov 18, 2018
| iriscli bank broadcast [file] | ||
| ``` | ||
| The transaction will broadcast and executed in IRISnet. | ||
|
|
There was a problem hiding this comment.
The transaction will broadcast and executed in IRISnet.
Remove this line, or change it as:
The transaction will be broadcasted and executed in blockchain.
HaoyangLiu
reviewed
Nov 18, 2018
| Send signature transaction: | ||
| ```bash | ||
| iriscli bank sign [file] --chain-id=[chain-id] --name [key name of from account] | ||
| ``` |
There was a problem hiding this comment.
I think [key name] is enough. Keep consistent with other specs.
HaoyangLiu
reviewed
Nov 18, 2018
| ``` | ||
| Save the result to a file. | ||
|
|
||
| Send signature transaction: |
There was a problem hiding this comment.
Send signature transaction:
Add signature to this transaction
chengwenxi
force-pushed
the
feature/docs
branch
from
39ee58b to
425a6c2
Compare
HaoyangLiu
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.