-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: irishub gov module docs #621
Conversation
Good job! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, we only need a little improvement
docs/cli-client/gov/README.md
Outdated
|
||
IRIShub Gov module allows you to submit proposals, vote and query the governance information you care about on the chain: | ||
1. Any users can deposit some tokens to initiate a proposal. Once deposit reaches a certain value min_deposit, enter voting period, otherwise it will remain in the deposit period. Others can deposit the proposals on the deposit period. Once the sum of the deposit reaches min_deposit, enter voting period. However, if the block-time exceeds max_deposit_period in the deposit period, the proposal will be closed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate from Extended description
, can we remove it here ? cli-client
documents only aim to show users how to use iris from command line, we have a feature
documents to declare the details of our modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it
docs/cli-client/gov/README.md
Outdated
| ------------------------------------- | --------------------------------------------------------------- | | ||
| [query-proposal](query-proposal.md) | Query details of a single proposal | | ||
| [query-proposals](query-proposals.md) | query proposals with optional filters | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could keep the first letter of description uppercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
docs/cli-client/gov/deposit.md
Outdated
| --gas | 200000 | [string] gas limit to set per-transaction; set to "simulate" to calculate required gas automatically | | | ||
| --gas-adjustment | 1 | [float] adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored | | | ||
| --generate-only | | Build an unsigned transaction and write it to STDOUT | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for deposit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/cli-client/gov/pull-params.md
Outdated
| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| --chain-id | | [string] Chain ID of tendermint node | | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for pull-params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/cli-client/gov/query-deposit.md
Outdated
| --chain-id | | [string] Chain ID of tendermint node | Yes | | ||
| --depositer | | [string] bech32 depositer address | Yes | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for query-deposit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| --chain-id | | [string] Chain ID of tendermint node | Yes | | ||
| --depositer | | [string] (optional) filter by proposals deposited on by depositer | | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for query-proposals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
iriscli gov query-proposals --chain-id=test | ||
``` | ||
|
||
After that, you're done with depositing iris tokens for an activing proposal, and remember to back up your proposal-id, it's the only way to retrieve your proposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TO DO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
docs/cli-client/gov/query-tally.md
Outdated
| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| --chain-id | | [string] Chain ID of tendermint node | Yes | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for query-tally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/cli-client/gov/query-vote.md
Outdated
| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| --chain-id | | [string] Chain ID of tendermint node | Yes | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for query-vote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/cli-client/gov/query-votes.md
Outdated
| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| --chain-id | | [string] Chain ID of tendermint node | Yes | | ||
| --height | | [int] block height to query, omit to get most recent provable block | | | ||
| --help, -h | | help for submit-proposal | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help for query-votes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
No description provided.