Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: irishub gov module docs #621

Merged
merged 8 commits into from
Nov 16, 2018
Merged

Conversation

trevorfu
Copy link
Contributor

No description provided.

@trevorfu trevorfu changed the title irishub gov module docs WIP: irishub gov module docs Nov 15, 2018
@HaoyangLiu
Copy link

Good job!

@trevorfu trevorfu changed the title WIP: irishub gov module docs R4R: irishub gov module docs Nov 16, 2018
Copy link
Contributor

@zhangyelong zhangyelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, we only need a little improvement


IRIShub Gov module allows you to submit proposals, vote and query the governance information you care about on the chain:
1. Any users can deposit some tokens to initiate a proposal. Once deposit reaches a certain value min_deposit, enter voting period, otherwise it will remain in the deposit period. Others can deposit the proposals on the deposit period. Once the sum of the deposit reaches min_deposit, enter voting period. However, if the block-time exceeds max_deposit_period in the deposit period, the proposal will be closed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate from Extended description, can we remove it here ? cli-client documents only aim to show users how to use iris from command line, we have a feature documents to declare the details of our modules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

| ------------------------------------- | --------------------------------------------------------------- |
| [query-proposal](query-proposal.md) | Query details of a single proposal |
| [query-proposals](query-proposals.md) | query proposals with optional filters |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could keep the first letter of description uppercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

| --gas | 200000 | [string] gas limit to set per-transaction; set to "simulate" to calculate required gas automatically | |
| --gas-adjustment | 1 | [float] adjustment factor to be multiplied against the estimate returned by the tx simulation; if the gas limit is set manually this flag is ignored | |
| --generate-only | | Build an unsigned transaction and write it to STDOUT | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for deposit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| --chain-id | | [string] Chain ID of tendermint node | |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for pull-params

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

| --chain-id | | [string] Chain ID of tendermint node | Yes |
| --depositer | | [string] bech32 depositer address | Yes |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for query-deposit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

| --chain-id | | [string] Chain ID of tendermint node | Yes |
| --depositer | | [string] (optional) filter by proposals deposited on by depositer | |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for query-proposals

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

iriscli gov query-proposals --chain-id=test
```

After that, you're done with depositing iris tokens for an activing proposal, and remember to back up your proposal-id, it's the only way to retrieve your proposal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO DO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| --chain-id | | [string] Chain ID of tendermint node | Yes |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for query-tally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| --chain-id | | [string] Chain ID of tendermint node | Yes |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for query-vote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

| --------------- | -------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| --chain-id | | [string] Chain ID of tendermint node | Yes |
| --height | | [int] block height to query, omit to get most recent provable block | |
| --help, -h | | help for submit-proposal | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help for query-votes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zhangyelong zhangyelong merged commit a58faee into irisnet:feature/docs Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants