-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Update doc for record module #607
Conversation
docs/zh/cli-client/record/README.md
Outdated
| --------------- | ------- | --------------- | -------- | | ||
| --help, -h | | 存证命令帮助 | | | ||
|
||
## 扩展描述 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成## 存证模块的介绍
可否把这块挪到相关命令
之前,把英文文档也做这个调整
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
iriscli record download --chain-id=test --record-id=MyRecordID --file-name="download.txt" | ||
``` | ||
|
||
在这之后,你将在iriscli的home目录下得到指定存证ID的下载文件。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iriscli会先在home目录(default: ~/.irislci)中创建一个用户指定的文件(download.txt),然后把从链上下载的数据保存在此文件中。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/zh/cli-client/record/query.md
Outdated
iriscli record query --chain-id=test --record-id=MyRecordID | ||
``` | ||
|
||
在这之后,你将得到存证ID指定的存证的详细信息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
查询到的结果如下所示:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/zh/cli-client/record/submit.md
Outdated
iriscli record submit --chain-id="test" --onchain-data="this is my on chain data" --from=node0 --fee=0.1iris | ||
``` | ||
|
||
在这之后你已经成功提交了一个存证,但是请记得备份你的存证ID,它是可以用来检索你的存证的唯一方法。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改成
运行成功以后,返回的结果如下:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
} | ||
} | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加上
本次存证操作的record-id如下:
`"record-id": "record:ab5602bac13f11737e8798dd57869c468194efad2db37625795f1efd8d9d63c6"`
请务必备份record-id,以备将来查询本次存证。若丢失record-id,本次存证再也无法查询到。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/modules/record/README.md
Outdated
|
||
## Usage | ||
## Interaction Process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Interactive
is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/modules/record/README.md
Outdated
|
||
```shell | ||
iriscli record [command] | ||
### Record process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Record Introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/modules/record/README.md
Outdated
|
||
## Usage Scenarios | ||
|
||
### Build Usage Scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section can be removed. Instead, you can suggest user to start a private testnet and offer a document about how to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will remove [Build Usage Scenarios] section. And maybe we could add how-to-setup-private-testnet doc in a totally separated doc later for general purpose.
docs/modules/record/README.md
Outdated
{ | ||
"tags": { | ||
"action": "submit-record", | ||
"completeConsumedTxFee-iris-atto": "\u0002\ufffd\ufffd\ufffd\ufffd\ufffd\u0000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The response changed:
"completeConsumedTxFee-iris-atto": "97720000000000",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/modules/record/README.md
Outdated
iriscli record [command] | ||
### Record process | ||
|
||
1. Any users can initiate a record request. It will cost you some tokens. If there’s no record of the data on the existing chains, the request will be completed successfully and the relevant metadata will be recorded onchain. And you will be returned a record ID to confirm your ownership of the data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there’s no record of the data on the existing chains, the request will be completed successfully and the relevant metadata will be recorded onchain.
How about change the above sentences to this:
If there’s no identical data on the targt chain, the request will be completed successfully and the metadata of record payload will be recorded on the target chain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/modules/record/README.md
Outdated
1. Any users can initiate a record request. It will cost you some tokens. If there’s no record of the data on the existing chains, the request will be completed successfully and the relevant metadata will be recorded onchain. And you will be returned a record ID to confirm your ownership of the data. | ||
2. If any others initiate a record request for the same data, the request will be directly rejected and it will hint that the relevant record data has already existed. | ||
3. Any users can search/download onchain based on the record ID. | ||
4. At present, the maximum amount of stored data at most 1K Bytes. In the future, the dynamic adjustment of parameters will be implemented in conjunction with the governance module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add description about the architecture of the record module. Please include these points:
- Where the recording payload will be saved?
- What is the metadata and how to generate it?
- Why do we adopt this strategy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestions are as follows:
- Record payload is saved on the target chain as the statement "the metadata of record payload will be recorded on the target chain" says. So I think maybe there's no need to emphasize this again.
- I will introduce the meanings of each component in the record metadata.
- Record module which enables generating corresponding metadata from uploaded data on the target chain, and it's public and can NOT be tampered with. And that's the way you declare data sovereignty by blockchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
No description provided.