Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail document generation for sphinx warnings #155

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

shabeebk
Copy link
Contributor

The repository was allowing warnings to be ignored by the sphinx while documents were generated. With this commit, we are now enforcing fail-on warnings. Current warnings are also fixed.

Repository was allowing warning to be ignored by the sphinx while documents are generated.
With this commit, we are now enforcing fail on warning.
Current warning are also fixed.
@shabeebk shabeebk force-pushed the sk-fix-sphinx-warnings branch from 43cdc22 to b60fad1 Compare December 16, 2024 19:53
Copy link
Contributor

@rbrazinskas rbrazinskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggrestion, otherwise LGTM

Co-authored-by: Ricardas Brazinskas <[email protected]>
rbrazinskas
rbrazinskas previously approved these changes Dec 17, 2024
@shabeebk shabeebk merged commit 906b643 into main Dec 17, 2024
16 checks passed
@shabeebk shabeebk deleted the sk-fix-sphinx-warnings branch December 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants