Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circuit_duration_check from RunRequest, add max_circuit_duration_over_t2 #114

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Remove circuit_duration_check from RunRequest, add max_circuit_duration_over_t2 #114

merged 3 commits into from
Feb 13, 2024

Conversation

ollityrkko
Copy link
Contributor

Adapt to CoCoS v23

jkotilahti
jkotilahti reviewed Feb 12, 2024
View reviewed changes
Copy link
Member

@jkotilahti jkotilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor issues with docstrings, it looks good to me. I will approve after also the Cocos changes can be checked.

@ollityrkko ollityrkko merged commit 80abaf4 into main Feb 13, 2024
13 checks passed
@ollityrkko ollityrkko deleted the update-circuit-duration-check branch February 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotilahti jkotilahti jkotilahti approved these changes

@kukushechkin kukushechkin Awaiting requested review from kukushechkin

@smite smite Awaiting requested review from smite

@rbrazinskas rbrazinskas Awaiting requested review from rbrazinskas

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ollityrkko @jkotilahti