Change clap bounds for Command from Parser to FromArgMatches
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clap has a separate `Subcommand` trait which is used instead of `Parser` on enums which represent subcommands. For that reason `Command` can't directly bound on `Parser` and still be usable for subcommand enums. Instead this commit changes `Command` to bound on the more general `clap::FromArgMatches` trait and moves the `clap::Parser` bound to the relevant methods for parsing toplevel arguments such as `parse_args` and `parse_env_args`.
Shella
approved these changes
Jan 18, 2022
|
Going to try this out on a local TMKMS branch and see if it fixes the problem |
|
Finally managed to get TMKMS compiled/working |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap has a separate
Subcommandtrait which is used instead ofParseron enums which represent subcommands.For that reason
Commandcan't directly bound onParserand still be usable for subcommand enums.Instead this commit changes
Commandto bound on the more generalclap::FromArgMatchestrait and moves theclap::Parserbound to the relevant methods for parsing toplevel arguments such asparse_argsandparse_env_args.