Completely replace lazy_static with once_cell
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates all previous usages of `lazy_static`, including in the new application template, with an `AppCell` type which is based on `OnceCell`. Unlike `lazy_static`, `OnceCell` does not require macros, and because of that can be hidden within the framework as an implementation detail. It's also on track for potential inclusion in the standard library, which would allow us to eventually eliminate it as a dependency: rust-lang/rfcs#2788 Overall, the previous usage patterns for `lazy_static` were hacking around the lack of a `OnceCell`-like API, so this is a net win.
tarcieri
force-pushed
the
replace-lazy_static-with-once_cell-part-deux
branch
from
27cf02c to
cb4ec93
Compare
tony-iqlusion
deleted the
replace-lazy_static-with-once_cell-part-deux
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates all previous usages of
lazy_static, including in the new application template, with anAppCelltype which is based onOnceCell.Unlike
lazy_static,OnceCelldoes not require macros, and because of that can be hidden within the framework as an implementation detail.It's also on track for potential inclusion in the standard library, which would allow us to eventually eliminate it as a dependency:
rust-lang/rfcs#2788
Overall, the previous usage patterns for
lazy_staticwere hacking around the lack of aOnceCell-like API, so this is a net win.