Use the failure_derive crate
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
use-failure-derive
branch
2 times, most recently
from
9e72ea2 to
e309466
Compare
Previously the code for `failure_derive` was vendored, with the long-term goal of modifying it/enhancing it with some framework-specific concerns. However, `failure_derive` is a dependency of `failure` so we pull it in anyway. Might as well use it, as opposed to cherry-picking a bunch of upstream changes to proc macro code.
tarcieri
force-pushed
the
use-failure-derive
branch
from
e309466 to
f6125bb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code for
failure_derivewas vendored, with the long-term goal of modifying it/enhancing it with some framework-specific concerns.However,
failure_deriveis a dependency offailureso we pull it in anyway. Might as well use it, as opposed to cherry-picking a bunch of upstream changes to proc macro code.