Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better warnings #838

Merged
merged 8 commits into from
Apr 7, 2023
Merged

Better warnings #838

merged 8 commits into from
Apr 7, 2023

Conversation

NickCrews
Copy link
Contributor

Fixes #837

NickCrews and others added 6 commits March 20, 2023 13:46
@NickCrews
Replace FutureWarnings with DeprecationWarnings
ba2a5a1 
per https://docs.python.org/3/library/warnings.html#warning-categories,
FutureWarnings are intended for end users, and DeprecationWarnings are for
programmers. We are targetting programmers here. 

This is a step towards fixing
ipython#837
@NickCrews
ref: remove unused _names_re
b2a3c84 
this is private and unused.
@NickCrews
feat: Always include stacklevel when warn()ing
4454d97 
Fixes ipython#837
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
62263d4 
for more information, see https://pre-commit.ci
@blink1073
fix import
36c5c82
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7166127 
for more information, see https://pre-commit.ci
blink1073
blink1073 approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 changed the title Better warnings Better warnings (#838)Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]> Apr 7, 2023
@blink1073 blink1073 merged commit 5cbf807 into ipython:main Apr 7, 2023
@blink1073 blink1073 changed the title Better warnings (#838)Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Steven Silvester <[email protected]> Better warnings Apr 7, 2023
@manics manics mentioned this pull request Apr 16, 2023
Closed
@minrk minrk mentioned this pull request Apr 17, 2023
Merged
@manics manics mentioned this pull request Apr 17, 2023
Closed
@vtnate vtnate mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: use of warnings.warn() does not always include stacklevel
2 participants
@NickCrews @blink1073