Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not catch system exceptions like KeyboardInterrupt #509

Merged
merged 1 commit into from
Apr 5, 2019
Merged

do not catch system exceptions like KeyboardInterrupt #509

merged 1 commit into from
Apr 5, 2019

Conversation

albertz
Copy link
Contributor

@albertz albertz commented Feb 1, 2019

You never should use except: in general. In this case, you probably do not want to catch exceptions like KeyboardInterrupt.

@albertz
do not catch system exceptions like KeyboardInterrupt
6139473 
You never should use `except:` in general. In this case, you probably do not want to catch exceptions like `KeyboardInterrupt`.
@minrk minrk merged commit 3eea7fc into ipython:master Apr 5, 2019
@minrk
Copy link
Member

minrk commented Apr 5, 2019

Good catch, thanks

@Carreau Carreau added this to the 5.0 milestone Jun 4, 2020
@Carreau Carreau added 5.0-re-review Need to re-review for potential API impact changes. 5.0-minor rereviewed, minor change need to be put in changelog. and removed 5.0-re-review Need to re-review for potential API impact changes. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0-minor rereviewed, minor change need to be put in changelog.
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@albertz @minrk @Carreau