Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Callable Trait #333

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Add a Callable Trait #333

merged 1 commit into from
Oct 25, 2016

Conversation

rmorshea
Copy link
Contributor

Closes #321

@Carreau Carreau merged commit f14057a into ipython:master Oct 25, 2016
@Carreau
Copy link
Member

Carreau commented Oct 25, 2016

Thanks !

danielballan added a commit to danielballan/traitlets that referenced this pull request May 22, 2019
@danielballan
DOC: Add Callable to docs.
457645c 
Missed in ipython#333, as noted in ipython#321 (comment).

Thanks!
@danielballan danielballan mentioned this pull request May 22, 2019
Merged
@krinsman
Copy link
Contributor

krinsman commented Aug 8, 2019

Is there anywhere to look to track the progress towards releasing 4.3.3?

Despite this being merged nearly three years ago, Callable hasn't been included in any releases yet, so when installing traitlets from conda, it's not possible to import Callable.

(Which is really frustrating since it would be perfect for my use case. Yes the definition is simple and it would be possible to essentially copy-paste it into my code, and that's what I'll do, but of course it's not very elegant compared to from traitlets import Callable, nor "official".)

rmorshea added a commit that referenced this pull request May 19, 2020
@rmorshea
Merge pull request #555 from timkpaine/callable
2b4f660 
cherrypick #333 and #523 onto 4.3.x
@Carreau Carreau added this to the 5.0 milestone Jun 4, 2020
@Carreau Carreau added the 5.0-re-review Need to re-review for potential API impact changes. label Jun 4, 2020
@Carreau
Copy link
Member

Carreau commented Jun 4, 2020

Is there anywhere to look to track the progress towards releasing 4.3.3?

I'm starting to re-review all the work that has been done in the past 3 years and we're going to see how we want to move forward. Either backport some to 4.x and say that we give up on 5.x or do a 5.0.

@Carreau Carreau added 5.0-major Major change in 5.0 need proper documentation and removed 5.0-re-review Need to re-review for potential API impact changes. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.0-major Major change in 5.0 need proper documentation
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Add a callable traitlet type
3 participants
@rmorshea @Carreau @krinsman