-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create All Default Values With Generators #332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6f8390
to
9e8419c
Compare
9e8419c
to
a8e0443
Compare
rmorshea
added a commit
to rmorshea/notebook
that referenced
this pull request
Nov 2, 2016
takluyver
added a commit
to jupyter/notebook
that referenced
this pull request
Nov 2, 2016
[WIP] fix for default value changes in ipython/traitlets/pull/332
Carreau
pushed a commit
to Carreau/jupyter_notebook
that referenced
this pull request
Nov 10, 2016
…aitlets/pull/332 Closes ipython/traitlets#342 All default values are now cross validated.
This was referenced Nov 10, 2016
cc @minrk |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
note: all default values (including those defined in trait constructors) are now cross validated