Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use packaging instead of pkg_resources to parse versions #900

Merged
merged 1 commit into from
Apr 1, 2022
Merged

use packaging instead of pkg_resources to parse versions #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ipykernel/eventloops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from functools import partial

import zmq
from pkg_resources import parse_version as V
from packaging.version import Version as V
from traitlets.config.application import Application


Expand Down
2 changes: 1 addition & 1 deletion ipykernel/tests/test_message_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import jupyter_client
import pytest
from pkg_resources import parse_version as V
from packaging.version import Version as V
from traitlets import (
Bool,
Dict,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def run(self):
'appnope;platform_system=="Darwin"',
"psutil",
"nest_asyncio",
"setuptools>=60", # for pkg_resources
"packaging",
],
extras_require={
"test": [
Expand Down