Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add a nix package #392

Merged
merged 1 commit into from
Oct 20, 2023
Merged

chore: add a nix package #392

merged 1 commit into from
Oct 20, 2023

Conversation

walkah
Copy link
Contributor

@walkah walkah commented Oct 20, 2023

Description

Adding a default package definition to the flake (and also tests the build in CI)

Link to issue

Related to #362

Type of change

  • New feature (non-breaking change that adds functionality)

Please delete options that are not relevant.

Test plan (required)

The nix workflow will now build the default homestar package

@walkah walkah requested a review from a team as a code owner October 20, 2023 19:06
zeeshanlakhani
zeeshanlakhani approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@zeeshanlakhani zeeshanlakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we're using nix build!

@walkah walkah merged commit 41b11df into main Oct 20, 2023
@walkah walkah deleted the walkah/nix-package branch October 20, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeeshanlakhani zeeshanlakhani zeeshanlakhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walkah @zeeshanlakhani