Testing: integration test refactoring #491
Assignees
Comments
2 tasks
|
We've decided to punt on the last two checkboxes here. We may return to them in the future. |
zeeshanlakhani
pushed a commit
that referenced
this issue
Jan 24, 2024
# Description @euamcg added a macro for inlining toml configs for tests. As we can see the amount of .toml configs is getting quite large. The macro allows us to write toml configs inside tests, create a fixture file, and discard it when the test is finished. This closes #485 and #491 (for now, as we may come back to some optimizations down the line related to the latter). ## Link to issue - [Issue#485](#485) - [Issue#491](#491) ## Type of change - [X] Refactor (non-breaking change that updates existing functionality) - [X] This change requires a documentation update Please delete options that are not relevant. ## Test plan (required) All tests are passing. --------- Co-authored-by: Euan McGinness <[email protected]> Co-authored-by: Euan McGinness <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
As our codebase grows, we want to make working with integration tests easier!
Components
Set RPC/HTTP ports to 0 in test configurations and have the OS choose an unused port for all RPC/HTTP servers (via @QuinnWilton). Note: TCP listeners in Rust do this automatically with bind and using the TcpListenerStream -> https://github.com/hyperium/tonic/blob/master/tests/integration_tests/tests/timeout.rs#L79.Use:memoryDB configuration name in integration tests to remove the need for named setup/teardown. This should be isolated per test due to be running within a child proc.The text was updated successfully, but these errors were encountered: