-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method Thermoprops and analyitical solution for CubicEoS #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #90 +/- ##
==========================================
- Coverage 94.03% 92.05% -1.99%
==========================================
Files 54 54
Lines 2432 2543 +111
Branches 183 190 +7
==========================================
+ Hits 2287 2341 +54
- Misses 99 154 +55
- Partials 46 48 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big API overhaul with also some improvements.
This pull request should be considered as yaeos 1.0 since it is a big API breaker and we should adopt semantic versioning https://semver.org/
thermoprops
module is a method ofArModel
. This makes it easier to override specific implementations. Mostly volume solving that was the main concern in this branch, each method could have an specific volume solver.yaeos_math
and it is now it is used to obtain CubicEoS volume roots.TODO:
@SalvadorBrandolin if you have time, could you add two tests?
yaeos__models_ar
)