feat: implement Eq for Ipld #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the `Eq` trait for the `Ipld` enum. NaN floats are never equal to another. Though in the Ipld Data model they are forbidden. This means that we can implement `Eq` for it. As it's currently not strictly enforced that an `Ipld::Float` does not contain a NaN, we make at least sure that in case we would encounter it, that it is treated as equal. For more information about the dicussion about this topic, see ipld/libipld#171.
rvagg
reviewed
Mar 28, 2024
| // NaN floats are forbidden in the IPLD Data Model, but still make sure they are treated as | ||
| // equal in case they accidentally end up there. | ||
| #[test] | ||
| fn test_partial_eq_nan() { |
There was a problem hiding this comment.
What happens when you compare different nans? Try a 3-way comparison between f64::NAN with f64::from_ne_bytes([0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0xf0, 0x7f]) and f64::from_ne_bytes([0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x7f]), they're all going to be "equal" aren't they? How much do we care about such things? (Also one of the reasons that NaN is forbidden).
There was a problem hiding this comment.
IMO, it's okay to define these as equal. Especially given that we'll reject all these when we serialize and deserialize them.
Stebalien
approved these changes
Mar 28, 2024
| // NaN floats are forbidden in the IPLD Data Model, but still make sure they are treated as | ||
| // equal in case they accidentally end up there. | ||
| #[test] | ||
| fn test_partial_eq_nan() { |
There was a problem hiding this comment.
IMO, it's okay to define these as equal. Especially given that we'll reject all these when we serialize and deserialize them.
|
whatever, 🙈 🙉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
Eqtrait for theIpldenum. NaN floats are never equal to another. Though in the Ipld Data model they are forbidden. This means that we can implementEqfor it.As it's currently not strictly enforced that an
Ipld::Floatdoes not contain a NaN, we make at least sure that in case we would encounter it, that it is treated as equal.For more information about the dicussion about this topic, see ipld/libipld#171.