Allow parsing padding in dag-json bytes fields #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we specify that the bytes field in dag-json is canonically the un-padded variant of the base64 encoding, there are existing records / dags created on versions of this library which did use padding. We should be able to parse these nodes.
warpfork
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
I'm not hyped about this, and would prefer in general if our codecs supported fewer baroque variations on data... but Postel's Principle does seem to apply in this case.
(Lesson for when we work on new codecs in the future: make a much, much bigger point of making sure we are driving with fixtures and strictness from the start.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we specify that the bytes field in dag-json is canonically the un-padded variant of the base64 encoding, there are existing records / dags created on versions of this library which did use padding. We should be able to parse these nodes.