add a SkipNext method on block reader
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Oct 19, 2022
| } | ||
|
|
||
| if sctSize == 0 { | ||
| _, _, err := cid.CidFromBytes([]byte{}) |
There was a problem hiding this comment.
Props for this hack to get the right error msg
rvagg
reviewed
Oct 19, 2022
rvagg
reviewed
Oct 19, 2022
rvagg
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
lgtm if it serves purpose, although I'm a little skeptical that the skipping is going to save much aside from passing slices around given the likely layering of buffered reads down to the OS and the size of our blocks being relatively small. But maybe that's worth it?
Co-authored-by: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #337