Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CODEOWNERS approval for go-car #51

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

BigLep
Copy link
Contributor

@BigLep BigLep commented Mar 22, 2023

Summary

Require CODEOWNERS approval for go-car

Why do you need this?

This is in support of ipld/go-car#403, where want to ensure a go-car CODEOWNER is approving PRs.

What else do we need to know?

Inspiration was taken from https://github.com/ipld/github-mgmt/blob/master/docs/EXAMPLE.yml

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep requested a review from rvagg March 22, 2023 04:18
@BigLep BigLep requested review from a team as code owners March 22, 2023 04:18
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipld

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_branch_protection.this["go-car:master"] will be created
  + resource "github_branch_protection" "this" {
      + allows_deletions                = false
      + allows_force_pushes             = false
      + enforce_admins                  = false
      + id                              = (known after apply)
      + pattern                         = "master"
      + repository_id                   = "MDEwOlJlcG9zaXRvcnkxNDM3NzM2NjA="
      + require_conversation_resolution = false
      + require_signed_commits          = false
      + required_linear_history         = false

      + required_pull_request_reviews {
          + dismiss_stale_reviews           = false
          + require_code_owner_reviews      = true
          + required_approving_review_count = 1
          + restrict_dismissals             = false
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@BigLep
Copy link
Contributor Author

BigLep commented Mar 22, 2023

@galargh : lfeedback welcome on whether am doing this right. I'm not sure whether I have required_status_checks filled in correctly. (I don't want any status checks to be required currently.). I think I'm doing this right based on https://registry.terraform.io/providers/integrations/github/latest/docs/resources/branch_protection but don't now.

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks correct :) We weren't tracking specific branch_protection settings in this org so far. That's why all the other branch_protection entries were just {}, and there was nowhere to draw inspiration from. I now enabled it.

@galargh
Copy link
Contributor

galargh commented Mar 22, 2023

Please dismiss the failing CircleCI check. We never had CircleCI configured here.

@rvagg rvagg merged commit 2a1454f into master Mar 24, 2023
@rvagg rvagg deleted the biglep/go-car/require-codeowners-approval branch March 24, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants