-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require CODEOWNERS approval for go-car #51
Conversation
This is in support of ipld/go-car#403 Inspiration taken from https://github.com/ipld/github-mgmt/blob/master/docs/EXAMPLE.yml
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipld
|
@galargh : lfeedback welcome on whether am doing this right. I'm not sure whether I have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks correct :) We weren't tracking specific branch_protection settings in this org so far. That's why all the other branch_protection entries were just {}
, and there was nowhere to draw inspiration from. I now enabled it.
Please dismiss the failing CircleCI check. We never had CircleCI configured here. |
Summary
Require CODEOWNERS approval for go-car
Why do you need this?
This is in support of ipld/go-car#403, where want to ensure a go-car CODEOWNER is approving PRs.
What else do we need to know?
Inspiration was taken from https://github.com/ipld/github-mgmt/blob/master/docs/EXAMPLE.yml
DRI: myself
Reviewer's Checklist