Skip to content
This repository was archived by the owner on Feb 8, 2023. It is now read-only.

Create 2018-08-20--js-core-dev-team-weekly.md #682

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Aug 20, 2018

Note the meeting ended abruptly due to another meeting starting that had the same host or id. Possibly the go weekly?

  • Recording needs to be added

@ghost ghost assigned jacobheun Aug 20, 2018
@ghost ghost added the status/in-progress In progress label Aug 20, 2018
@jacobheun jacobheun requested a review from alanshaw August 20, 2018 17:03
@jacobheun
Copy link
Contributor Author

The discussion in irc #ipfs-dev makes it appear that it was indeed an issue with the js and go meetings clashing. fyi @diasdavid

@ghost ghost assigned alanshaw Aug 20, 2018
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit 13a0de0 into master Aug 20, 2018
@ghost ghost removed the status/in-progress In progress label Aug 20, 2018
@jacobheun jacobheun deleted the jscore/20180820 branch August 20, 2018 17:51
@djdv
Copy link
Contributor

djdv commented Aug 20, 2018

Note the meeting ended abruptly due to another meeting starting that had the same host or id. Possibly the go weekly?

My bad! ❤️

@daviddias
Copy link
Member

Note the meeting ended abruptly due to another meeting starting that had the same host or id.

Interesting. I definitely created two different meetings, but perhaps given the fact that they are both associated with my account makes it that Zoom assumes I can't be in both at the same time.

This is a good reminder to stay on time :)


@vmx
- Done:
- (already last week): Describe your DAG in a text file: https://github.com/vmx/dagbuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the goal of this module?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the Q&A below :)

@vmx
- Done:
- (already last week): Describe your DAG in a text file: https://github.com/vmx/dagbuilder
- Hello world libp2p (for GraphSync)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works? Is there a demo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a libp2p hello world to get me familiar with the code. So it would be the same as checking out the libp2p examples.

- delegate peer routing test updates are ready to merge https://github.com/libp2p/js-libp2p-delegated-peer-routing/pull/3
- Found an inconsistency issue when adding libp2p tests for delegate content routing. Fixed that, going to finish the libp2p tests for that today.
- Blocked:
- Go delegate route endpoints https://github.com/ipfs/go-ipfs/pull/4595. We can get the work finished for delegated peer/content routing, but it won't be functional until this is deployed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobheun can you open an issue on ipfs/infrastructure to track this ask?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, ipfs/infra#426, with links off to the blocking go-ipfs issue and js-libp2p core issue.

- Found an inconsistency issue when adding libp2p tests for delegate content routing. Fixed that, going to finish the libp2p tests for that today.
- Blocked:
- Go delegate route endpoints https://github.com/ipfs/go-ipfs/pull/4595. We can get the work finished for delegated peer/content routing, but it won't be functional until this is deployed.
- [ipfs-api#837](https://github.com/ipfs/js-ipfs-api/pull/837) will prevent me from finalizing my PR for libp2p content/delegate routing tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that @alanshaw handled this one for you :)

@daviddias daviddias added the 💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld label Sep 13, 2018
@jacobheun jacobheun added ⚡️ⒿⓈ Core Dev js-ipfs, js-libp2p and js-ipld and removed 💫 Golang Core Dev go-ipfs, go-libp2p, go-ipld labels Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚡️ⒿⓈ Core Dev js-ipfs, js-libp2p and js-ipld
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants