fix(gateway): return HTTP 500 on namesys.ErrResolveFailed #9589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
lidel
requested changes
Feb 15, 2023
There was a problem hiding this comment.
@hacdias mind rebasing? tests neeed to be moved to ipfs/boxo#150 because we've merged #9627
lidel
changed the title
hacdias
force-pushed
the
fix/9514
branch
2 times, most recently
from
88510a1 to
a6db9bb
Compare
|
@lidel I rebased. There are some unrelated tests failing. I checked and they've been failing in |
lidel
approved these changes
Feb 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9514.